Added time zone offset #47 #145
Conversation
joachimmetz
added
blocked
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 98.89% 98.84% -0.05%
==========================================
Files 20 20
Lines 1623 1652 +29
==========================================
+ Hits 1605 1633 +28
- Misses 18 19 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 98.89% 98.84% -0.05%
==========================================
Files 20 20
Lines 1623 1652 +29
==========================================
+ Hits 1605 1633 +28
- Misses 18 19 +1
Continue to review full report at Codecov.
|
| @@ -143,16 +143,16 @@ def CopyFromDateTimeString(self, time_string): | |||
| hours = date_time_values.get('hours', 0) | |||
| minutes = date_time_values.get('minutes', 0) | |||
| seconds = date_time_values.get('seconds', 0) | |||
| time_zone_offset = date_time_values.get('time_zone_offset', 0) | |||
There was a problem hiding this comment.
What does it mean for a FAT timestamp to have a timezone offset? Do you think it would be better to raise an error if a user specifies a offset in the string other than 0?
There was a problem hiding this comment.
Time zone offset represents if the date and time value has a time zone offset, not FAT specific. It is to support a time offset / time zone for date and time values.
| self._number_of_seconds -= self._FAT_DATE_TO_POSIX_BASE | ||
|
|
||
| self.is_local_time = False |
There was a problem hiding this comment.
Shouldn't this be True for FAT?
There was a problem hiding this comment.
is_local_time is used in a different way by plaso, it should be removed.
|
@Onager PTAL answered your questions |
Added time zone offset #47