Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve review scripts #40

Closed
18 tasks done
joachimmetz opened this issue Sep 12, 2015 · 1 comment
Closed
18 tasks done

improve review scripts #40

joachimmetz opened this issue Sep 12, 2015 · 1 comment
Assignees

Comments

@joachimmetz
Copy link
Member

joachimmetz commented Sep 12, 2015

  • Fix git pull issue on close
  • fix version not being updated on merge
  • Check why the rietveld close issue is still not working
    • missing cookie jar - use OAuth instead
  • change/remove missing test file script
  • Move review scripts to Python - to support Windows
    • update l2tdevtools script with plaso scripts
    • fix limitation in merge script that CL description cannot contain a ':'
    • add a submitted comment to code review
    • change http:// to https:// where possible
  • fix issue argparse yielding different results when run from review.py
  • review.py add functionality to "test"
  • review.py add option for unattended mode - do not ask for confirmation
  • review.py create - do not generate '[project_name]' in PR description
  • document usage of BROWSER environment variable
  • review.py "lint" add option to lint all files
  • update dfwinreg scripts
    • removed shell scripts
  • update dfvfs scripts
    • removed shell scripts
  • update plaso scripts
    • removed shell scripts
  • Provide pylint in l2tbinaries
  • https://codereview.appspot.com/309000043/
    • create - check if review file exists first
    • close - notify if review file is missing or codereview issue cannot be closed
    • close - support user:branch as input besides branch
    • added update-authors functionality
  • add lint_and_test option
  • fix issue with create --nobrowser
    • Create aborted - unable to create codereview issue.
    • Issue created message not at the start of the line

Remaining items moved to: https://github.com/log2timeline/l2treviewtools/issues/22

@rgayon
Copy link
Contributor

rgayon commented Nov 4, 2015

Only run python tests when python code was modified

joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Dec 29, 2015
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Dec 29, 2015
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Dec 29, 2015
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Dec 29, 2015
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Dec 29, 2015
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Feb 24, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Feb 24, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 6, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 6, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 6, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 6, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 6, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 6, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 6, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 6, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 6, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 9, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 9, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 9, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 9, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 9, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 9, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 9, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 9, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Aug 9, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Dec 31, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Dec 31, 2016
joachimmetz added a commit to joachimmetz/l2tdevtools that referenced this issue Dec 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants