Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to setup.py for bdist_rpm #2399

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

joachimmetz
Copy link
Member

Changes to setup.py for bdist_rpm

Copy link
Contributor

@rgayon rgayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes LGTM, though I have no idea why the test is broken

@joachimmetz
Copy link
Member Author

@rgayon tests could be failing due to #2400

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #2399 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2399      +/-   ##
==========================================
- Coverage   85.93%   85.92%   -0.02%     
==========================================
  Files         452      452              
  Lines       31996    31996              
==========================================
- Hits        27495    27491       -4     
- Misses       4501     4505       +4
Impacted Files Coverage Δ
plaso/engine/zeromq_queue.py 72.18% <0%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5fc33...09e1f6b. Read the comment docs.

@joachimmetz joachimmetz merged commit c8d2418 into log2timeline:master Mar 21, 2019
@joachimmetz joachimmetz deleted the setuprpm branch March 21, 2019 06:27
jeppetrost pushed a commit to jeppetrost/plaso that referenced this pull request Mar 25, 2019
jeppetrost pushed a commit to jeppetrost/plaso that referenced this pull request Mar 25, 2019
joachimmetz added a commit that referenced this pull request Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants