changing mrulist.entries from string to list of strings similar to windows_run #4739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chb2mn you'll need to update the tests and formatters as well |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4739 +/- ##
=======================================
Coverage 86.16% 86.16%
=======================================
Files 416 416
Lines 37574 37574
=======================================
Hits 32376 32376
Misses 5198 5198 ☔ View full report in Codecov by Sentry. |
|
updated docstrings of event data classes |
|
@joachimmetz any action needed from me? |
|
@chb2mn I've been preoccupied a bit, let me take a look this weekend and let you know. I recall that I wanted to test this end-to-end first. |
joachimmetz
force-pushed
the
mrulist_list
branch
from
ad103a5
to
95726b9
Compare
joachimmetz
force-pushed
the
mrulist_list
branch
from
95726b9
to
8676aa7
Compare
dafneb
added a commit
to dafneb/plaso
that referenced
this pull request
Dec 31, 2023
* Changes to use pyproject.toml (log2timeline#4756) * Added support for version 118 Firefox downloads database files (log2timeline#4749) * Corrected missing test file firefox_cookies.sqlite log2timeline#4757 (log2timeline#4758) * Updated pylintrc to version 3.0 (log2timeline#4761) * Changes for pyparsing 3.1 log2timeline#4580 (log2timeline#4760) * Updated documentation (log2timeline#4763) * Changes for BDE Windows CI tests log2timeline#4757 (log2timeline#4759) * Updated version and documentation (log2timeline#4764) * Changed mrulist parsers to produce list of entries (log2timeline#4739) * Updated release script and version (log2timeline#4767) * Changes for deployment (log2timeline#4768) * Changes for deployment (log2timeline#4770) * Changes to release GitHub issue template (log2timeline#4771) * Added readthedocs configuration (log2timeline#4772) * Changes to handling message file resource paths log2timeline#4259 (log2timeline#4773) --------- Co-authored-by: Joachim Metz <joachim.metz@gmail.com> Co-authored-by: Christopher Burkhalter <chb2mn@virginia.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One line description of pull request
changing mrulist.entries from string to list of strings similar to windows_run
Description:
Similar to winreg_default,
' '.join(data)is particularly hard to parse with just a regex. much easier to just push the original listChecklist: