Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogstashTcpSocketAppenderTest.testConnectOnPrimary is not stable #560

Closed
philsttr opened this issue Jul 7, 2021 · 0 comments · Fixed by #564
Closed

LogstashTcpSocketAppenderTest.testConnectOnPrimary is not stable #560

philsttr opened this issue Jul 7, 2021 · 0 comments · Fixed by #564
Labels
type/bug
Milestone
7.0

Comments

@philsttr
Copy link
Collaborator

philsttr commented Jul 7, 2021

Describe the bug

The LogstashTcpSocketAppenderTest.testConnectOnPrimary unit test fails occasionally.
Need to make it consistently pass.

To Reproduce
Run unit tests

Expected behavior
Unit test should pass every time
@philsttr philsttr mentioned this issue Jul 7, 2021
Merged
brenuart added a commit to brenuart/logstash-logback-encoder that referenced this issue Jul 8, 2021
@brenuart
Wait until the connect process is fully completed before asserting state
3e2d526 
Related issue: logfellow#560
@brenuart brenuart mentioned this issue Jul 8, 2021
Merged
@philsttr philsttr linked a pull request Jul 10, 2021 that will close this issue
Attempt at fixing #560 #564
Merged
philsttr pushed a commit that referenced this issue Jul 10, 2021
@brenuart
Wait until the connect process is fully completed before asserting st…
68b8be1 
…ate (#564)

Related issue: #560
@philsttr philsttr added this to the 7.0 milestone Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
7.0
Development

Successfully merging a pull request may close this issue.

Attempt at fixing #560 brenuart/logstash-logback-encoder
1 participant
@philsttr