Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow UuidProvider to be used with IAccessEvent #662

Closed
brenuart opened this issue Sep 23, 2021 · 1 comment
Closed

Allow UuidProvider to be used with IAccessEvent #662

brenuart opened this issue Sep 23, 2021 · 1 comment
Labels
type/enhancement
Milestone
7.0

Comments

@brenuart
Copy link
Collaborator

UuidProvider is currently restricted to ILoggingEvent but may be useful with IAccessEvent as well.
brenuart added a commit that referenced this issue Sep 23, 2021
@brenuart
Make UuidProvider usable with both ILoggingEvent and IAccessEvent
be6b82d 
Refactor UuidProvider and associate utility classes to make them usable for both ILoggingEvent and IAccessEvent:
- create a new UuidJsonProvider by making a copy of the existing UuidProvider (restricted to ILoggingEvent)
- deprecate the existing UuidProvider in favour of the common UuidJsonProvider
- move the LoggingEventJsonProviders#addUuid() method into the common JsonProviders class

Closes #662
@brenuart brenuart mentioned this issue Sep 23, 2021
Merged
@brenuart
Copy link
Collaborator Author

net.logstash.logback.composite.loggingevent.UuidProvider is now deprecated and replaced by net.logstash.logback.composite.UuidJsonProvider. This new version is usable for both ILoggingEvent and IAccessEvent.

brenuart added a commit that referenced this issue Sep 29, 2021
@brenuart
Make UuidProvider usable with both ILoggingEvent and IAccessEvent
c12b299 
Refactor UuidProvider and associate utility classes to make them usable for both ILoggingEvent and IAccessEvent:
- create a new UuidJsonProvider by making a copy of the existing UuidProvider (restricted to ILoggingEvent)
- deprecate the existing UuidProvider in favour of the common UuidJsonProvider
- move the LoggingEventJsonProviders#addUuid() method into the common JsonProviders class

Closes #662
@philsttr philsttr added this to the 7.0 milestone Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
7.0
Development

No branches or pull requests
2 participants
@brenuart @philsttr