Avoid potential race condition in DeferredLogstashMarker#getSuppliedV… #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue by not publishing a null LogstashMarker.
PascalSchumacher
force-pushed
the
DeferredLogstashMarker_avoid_potential_race_condition
branch
from
1391c08
to
a0f4b04
Compare
|
I don't think this actually fixes any race conditions, since the changed code is within a synchronized block, but I'll merge it anyway, since it removes a volatile read/write. |
|
On further thinking I belive you are correct. It is not a race condition, because only Sorry for the missleading comment and pull request title. :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alue by not publishing a null LogstashMarker.
By the way: Thank you very much for developing
logstash-logback-encoderand a happy new year!