getFieldValue() should return fieldValue without transforming it into a String
#720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rming it into a String `ObjectAppendingMarker#getFieldValue()` should ideally return the value of the `fieldValue` property without transformation. This method is intended to be used by `SingleFieldAppendingMarker#tselfToString()` that already takes care of converting the value into a String. closes #719
Codecov Report
@@ Coverage Diff @@
## main #720 +/- ##
============================================
+ Coverage 68.98% 69.02% +0.04%
Complexity 1192 1192
============================================
Files 160 160
Lines 4623 4623
Branches 458 458
============================================
+ Hits 3189 3191 +2
+ Misses 1186 1185 -1
+ Partials 248 247 -1
Continue to review full report at Codecov.
|
philsttr
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectAppendingMarker#getFieldValue()should ideally return the value of thefieldValueproperty without transformation. This method is intended to be used bySingleFieldAppendingMarker#selfToString()that already takes care of converting the value into a String.closes #719