Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

848 ipv6 support in DestinationParser #849

Merged
merged 3 commits into from
Aug 30, 2022
Merged

848 ipv6 support in DestinationParser #849

merged 3 commits into from
Aug 30, 2022

Conversation

brenuart
Copy link
Collaborator

Allow destinations to be specified with an IPv6 address enclosed between brackets (eg. [2001:db8::1]:8080).

closes #848

@brenuart brenuart linked an issue Aug 30, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #849 (90e75e5) into main (f7d231a) will increase coverage by 0.01%.
The diff coverage is 83.33%.

❗ Current head 90e75e5 differs from pull request most recent head 26f211e. Consider uploading reports for the commit 26f211e to get more accurate results

@@             Coverage Diff              @@
##               main     #849      +/-   ##
============================================
+ Coverage     70.86%   70.88%   +0.01%     
- Complexity     1271     1272       +1     
============================================
  Files           170      170              
  Lines          4854     4857       +3     
  Branches        507      508       +1     
============================================
+ Hits           3440     3443       +3     
  Misses         1160     1160              
  Partials        254      254              
Impacted Files Coverage Δ
...ogback/appender/destination/DestinationParser.java 95.23% <83.33%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@brenuart brenuart merged commit 8a836f1 into main Aug 30, 2022
@brenuart brenuart deleted the 848-ipv6-support branch August 30, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DestinationParser does not accept IPV6 addresses
2 participants