859 LogstashEncoder should throw IllegalArgumentException instead of logging an error status when attempting to use <providers> #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenuart
changed the title
Codecov Report
@@ Coverage Diff @@
## main #861 +/- ##
============================================
- Coverage 71.24% 71.23% -0.01%
- Complexity 1283 1284 +1
============================================
Files 170 170
Lines 4865 4867 +2
Branches 508 508
============================================
+ Hits 3466 3467 +1
- Misses 1146 1147 +1
Partials 253 253
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
brenuart
deleted the
859-logstashencoder-should-throw-illegalstateexception-instead-of-logging-an-error-status-when-attempting-to-add-extra-encoders
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make LogstashEncoder/Layout throw an IllegalArgumentException when an attempt is made to use the
<providers>configuration property.Also add a few words in the documentation about how to register additional JsonProvider to a LogstashEncoder.