-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust version is ridiculously unidiomatic #4
Comments
Sure, that'd be great. Maybe take a look a look at the C++ version, which wasn't written by me, as an example of a more structured approach. Would it be possible to change it without updating the syntax? I used depreciated OpenGL version 2.1 functions, and the Rust OpenGL library only supports version 4 functions, so as I couldn't get the OpenGL bindings generator to compile on my build of Rust I manually wrote the bindings I needed instead. They're in lib.rs, in the repo. If the syntax of R.rs is updated to require a recent build of Rust to run, then I'll have to rewrite those bindings, as I believe the Rust FFI has changed in the last couple of months. |
I had modified the GL binding generator so that it could generate bindings On Sat, Jan 4, 2014 at 8:19 PM, Jonathan Barnard
|
Awesome, thanks! If possible, could you also have a go at replacing the emptyPt and emptyVt objects? For instance in: |
It looks like it's basically a straight line-by-line port of the C. A more idiomatic version would be using methods on structs. Would you accept a PR that updates this to be more sane?
The text was updated successfully, but these errors were encountered: