Docker #14
Docker #14
Conversation
should be good to start testing - needs some work.
# Conflicts: # Server/server-config.sh
when running in docker it will reset the collector mysql password each time the container initializes.
add docker volumes for ssh key locations.
Will generate a new macOS install .pkg file in the /tmp/pkg directory when running client-config.sh within Docker
Fixed sql server in collector.php and move README.
every docker container had the same host key as it was baked in - this resolves and allows you to map the correct keys
Add BlueSky Admin tool auto-generation within docker container.
same fix as potential PR #9
# Conflicts: # Admin Tools/setup.applescript
also some README example path changes
resolve conflict with logicnow@23e21a11ba44db78589066af46a60 787fbba0df0 - we both tried to do the same thing.
# Conflicts: # Server/server-config.sh
# Conflicts: # Admin Tools/BlueSky Admin.app/Contents/Info.plist # Admin Tools/Info.plist # Admin Tools/connect/Info.plist # Admin Tools/connect/connect.applescript # Admin Tools/temporary client/temporary client.applescript
was reverting back to http on some requests.
add version variable, make mods to exclude admin tool raw scripts
Change SSL cert workflow. Update README. Small apache error fix
Wait for MySQL database to start
Better handling of installing over older (pre 2.0) bluesky. Also do a better job making sure the bluesky home permissions are correct. Spacing normalization
Update helper.sh
Bux fixes - bad mysql admin password logic in docker/run - helper.sh improvements when updating from pre 2.0 bluesky - fix webadmin password being reset on each container run
|
Just updated with some bugs that @kginger and I found. Please test against the latest here. |
| @@ -29,6 +29,12 @@ smtpServer="" | |||
| smtpAuth="" | |||
| smtpPass="" | |||
|
|
|||
| if [[ ${IN_DOCKER} && ${SMTP_SERVER} && ${SMTP_AUTH} && ${SMTP_PASS} ]]; then | |||
| smtpServer=$SMTP_SERVER | |||
There was a problem hiding this comment.
Walking through the docker setup in the readme, I did not see where to provide these.
There was a problem hiding this comment.
assume this is one of the comments you figured out later - in the docker/README.md (https://github.com/logicnow/BlueSky/pull/14/files#diff-a489144702a723431811d56a3c44690a) it lists these 3 SMTP ENV variables :)
Server/jail.local
Outdated
| filter = apache-phpmyadmin | ||
| logpath = /var/log/apache*/*error.log | ||
| maxretry = 3 | ||
| #[apache-phpmyadmin] |
There was a problem hiding this comment.
you are correct - i dont need to comment out - i may have gotten a bit over zealous. it just assumes that the user is using phpmyadmin which they may not (not part of the bluesky setup or instructions). i can uncomment in this PR and get this jail back to what it was.
| > **Note:** _We do not care about SSL certs here as the Caddy container will take care of that_ | ||
|
|
||
| ``` | ||
| docker run -d --name bluesky \ |
There was a problem hiding this comment.
Ah, here they are. I missed these on the first trial run.
There was a problem hiding this comment.
yes so in this first pass (i can do more in the future) i just focussed on adapting what you did for docker. that includes not really worrying about SSL much (no auto LetsEncrypt). I decided in the "full setup" example to walk the user through creating a caddy container which would provide SSL automatically for the bluesky container. in the case that the user did not want to do this and wanted to use their own certs i have a way to pass the cert and private key to the container which is have tested and works.
|
undid the jail.local comment block - not only necessary changes have been made |
|
woah |
OK - went through some last changes as we discussed. Just reviewed all the changes - I think this is all good - but please review to make sure I didnt miss anything.
My hope is this is a good staring point and I can make the docker container more mature as time goes on.