Test with the lowest possible dependencies as well #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have a look at the conflicts & failing tests (yay!) tomorrow, should just be some dependencies in |
The orchestra/database dependency was removed in v3.4.1, but its service provider was still being loaded. This was fixed in v3.4.2, so we'll require that at minimum. See the release notes: https://github.com/orchestral/testbench/releases/tag/v3.4.1
Since the prefer-stable option is already set to true in composer.json, this flag won't have any added benefit. To reduce the build time (by a third!), we'll remove it and only test with the '--prefer-lowest' flag, and nothing.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll introduce
--prefer-lowestas a Composer flag to run the tests against the lowest possible versions of all dependencies. This ensures maximum compatibility across as many versions as possible.It does, however, triple the amount of tests that are run per workflow run.