Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Go to this page" on header always goes to today #79

Closed
1 of 2 tasks
nckre opened this issue Sep 12, 2024 · 4 comments
Closed
1 of 2 tasks

"Go to this page" on header always goes to today #79

nckre opened this issue Sep 12, 2024 · 4 comments
Labels
bug Something isn't working can reproduce

Comments

@nckre
Copy link

nckre commented Sep 12, 2024

Search first

  • I searched and no similar issues were found

What Happened?

DB version introduced a "Go to this page" behind three dot menu that's visible on Journals, Graph view and All Pages.

This page always goes to current date, even if e.g. writing on one of the other dates in Journal.

CleanShot 2024-09-12 at 10 37 54

Reproduce the Bug

  1. Go to Graph view
  2. Click on three dot menu
  3. Click on "Go to this page"

Expected Behavior

No response

Screenshots

No response

Browser, Desktop or Mobile Platform Information

No response

Additional Context

No response

Are you willing to submit a PR? If you know how to fix the bug.

  • I'm willing to submit a PR (Thank you!)
@nckre
Copy link
Author

nckre commented Sep 12, 2024

Same is true for other options (delete, favorite, export).

They all just work for today's page - overall not convinced if these options add any value.

It takes two clicks to go from anywhere to current day (1. Home icon, 2. Click on top heading). Same number of clicks it takes to open the page via three-dot menu.

@logseq-cldwalker logseq-cldwalker changed the title Rename "Go to this page" to "Go to Today" "Go to this page" on header always goes to today Sep 12, 2024
@logseq-cldwalker logseq-cldwalker added bug Something isn't working can reproduce labels Sep 12, 2024
@logseq-cldwalker
Copy link
Contributor

Hi. I see this was added when doing block and page unification. I'm unsure of why this shows up on the header.
@tiensonqin Any thoughts on desired behavior here?

tiensonqin added a commit to logseq/logseq that referenced this issue Sep 15, 2024
@tiensonqin
Copy link
Contributor

Go to this page was added because previously clicking a journal's title will turn it into the editing mode, now it's deleted.

@nckre
Copy link
Author

nckre commented Sep 16, 2024

@tiensonqin seems like the other options (add to favs, delete, export) are still there.

If they stay, I would clarify that these actions are for today's page.

Say you scroll in your Journals, edit some page and then click "Export" → it will still export Today and not the page you're currently working on. This might be confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working can reproduce
Projects
None yet
Development

No branches or pull requests

3 participants