Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag inheritance only going one level deep #88

Closed
1 of 2 tasks
blogbourri opened this issue Sep 14, 2024 · 1 comment
Closed
1 of 2 tasks

tag inheritance only going one level deep #88

blogbourri opened this issue Sep 14, 2024 · 1 comment
Assignees
Labels
bug Something isn't working can reproduce in review

Comments

@blogbourri
Copy link

Search first

  • I searched and no similar issues were found

What Happened?

tag properties are inherited one level deep, but not beyond that. this doesn't seem to be the intended result, so i believe it is a bug.

Reproduce the Bug

  1. create a tag, #grandparent and give it a unique property
  2. create a tag, #parent and give it another unique property
  3. set the #grandparent as the parent of the #parent
  4. create a tag, #child and give it another unique property
  5. set the #parent as the parent of the #child
  6. create a block and give it just the #child tag
  7. the block only inherits properties from #parent, not from #grandparent

Expected Behavior

tag properties should inherit the full depth of the tag hierarchy

Screenshots

image

Browser, Desktop or Mobile Platform Information

No response

Additional Context

we tested an earlier version, and the behavior seemed to change at some point, though it's unclear if this was ever fully implemented or not

https://discord.com/channels/725182569297215569/1284519040303235133

Are you willing to submit a PR? If you know how to fix the bug.

  • I'm willing to submit a PR (Thank you!)
@tiensonqin tiensonqin self-assigned this Sep 15, 2024
@tiensonqin tiensonqin added the bug Something isn't working label Sep 15, 2024
tiensonqin added a commit to logseq/logseq that referenced this issue Sep 15, 2024
@tiensonqin
Copy link
Contributor

@blogbourri Thank you for the report, this should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working can reproduce in review
Projects
None yet
Development

No branches or pull requests

2 participants