Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Advanced Queries.md, may resolve #69 #114

Closed
wants to merge 1 commit into from

Conversation

YeungOnion
Copy link

Add info regarding how to find page/block data available to use in queries as well as listing the functions in the query dsl.

I think this could be vastly improved with someone who has a little more knowledge - I just couldn't find a way to see what was available to query when writing advanced queries on so I figured I'd start it out on the docs.

Add info regarding how to find page/block data available to use in queries as well as listing the functions in the query dsl.
- [Logseq's database schema](https://github.com/logseq/logseq/blob/master/deps/db/src/logseq/db/schema.cljs)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this link is broken, maybe it should point to the model file? https://github.com/logseq/logseq/blob/master/src/main/frontend/db/model.cljs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing an issue with the current link

@YeungOnion YeungOnion changed the title Update Advanced Queries.md Update Advanced Queries.md, may resolve #69 Oct 11, 2023
Copy link
Contributor

@logseq-cldwalker logseq-cldwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YeungOnion Hi. Thanks for trying to improve the docs. Happy to take the mention of the developer commands as described below

updated-at:: 1697057234
- You'll see example queries below that compose concepts expressed in this section.
View [comments in the source](https://github.com/logseq/logseq/blob/master/src/main/frontend/db/query_dsl.cljs/#L22-L48)
- #### Page data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see this being useful. Mentioning the 'Show page data' and 'Show block data' commands under Query Tips number 5 would be great.

@@ -138,6 +138,33 @@ description:: Advanced queries are written with [Datalog](https://en.wikipedia.o
- `:Xd-after-ms` - Timestamp of X days after today. **New syntax** `:+Xd-ms`
- `:start-of-today-ms` - Timestamp for beginning of today. **New syntax** `:today-start`
- `:end-of-today-ms` - Timestamp for end of today. **New syntax** `:today-end`
- ### Query parameters and functions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this section is already written in https://docs.logseq.com/#/page/queries and putting it in this page is unfortunately incorrect. There are already a couple of references to "simple query" in this page. I could link simple query to https://docs.logseq.com/#/page/queries if that helps

- [Logseq's database schema](https://github.com/logseq/logseq/blob/master/deps/db/src/logseq/db/schema.cljs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing an issue with the current link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants