Skip to content

Commit bee8fd9

Browse files
committed
remove outdated codesign
1 parent d1c8686 commit bee8fd9

File tree

1 file changed

+2
-44
lines changed

1 file changed

+2
-44
lines changed

.github/workflows/build-desktop-release.yml

Lines changed: 2 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -572,51 +572,9 @@ jobs:
572572
ANDROID_KEYSTORE_PASSWORD: "${{ secrets.ANDROID_KEYSTORE_PASSWORD }}"
573573
SENTRY_AUTH_TOKEN: "${{ secrets.SENTRY_AUTH_TOKEN }}"
574574

575-
codesign-windows:
576-
if: ${{ github.event_name == 'schedule' || github.event.inputs.build-target == 'nightly' || github.event.inputs.build-target == 'beta' }}
577-
needs: [ build-windows-x64, build-windows-arm64 ]
578-
runs-on: [self-hosted, macos, token]
579-
steps:
580-
- name: Remove old builds
581-
run: rm -rf ./builds && mkdir ./builds
582-
583-
- name: Download Windows x64 Artifact
584-
uses: actions/download-artifact@v4
585-
with:
586-
name: logseq-win-x64-unsigned-builds
587-
path: ./builds-x64
588-
589-
- name: Download Windows arm64 Artifact
590-
uses: actions/download-artifact@v4
591-
with:
592-
name: logseq-win-arm64-unsigned-builds
593-
path: ./builds-arm64
594-
595-
- name: Sign Windows Executable
596-
run: |
597-
ls -lah ./builds-x64
598-
jsign --storetype ETOKEN --storepass "${PASS}" -t http://timestamp.sectigo.com ./builds-x64/*.exe
599-
ls -lah ./builds-arm64
600-
jsign --storetype ETOKEN --storepass "${PASS}" -t http://timestamp.sectigo.com ./builds-arm64/*.exe
601-
env:
602-
PASS: ${{ secrets.CODE_SIGN_CERTIFICATE_PASSWORD }}
603-
604-
- name: Upload Artifact x64 (Signed)
605-
uses: actions/upload-artifact@v4
606-
with:
607-
name: logseq-win-x64-signed-builds
608-
path: builds-x64
609-
610-
- name: Upload Artifact arm64 (Signed)
611-
uses: actions/upload-artifact@v4
612-
with:
613-
name: logseq-win-arm64-signed-builds
614-
path: builds-arm64
615-
616-
617575
nightly-release:
618576
if: ${{ github.event_name == 'schedule' || github.event.inputs.build-target == 'nightly' }}
619-
needs: [ build-macos-x64, build-macos-arm64, build-linux-x64, build-linux-arm64, codesign-windows]
577+
needs: [ build-macos-x64, build-macos-arm64, build-linux-x64, build-linux-arm64]
620578
runs-on: ubuntu-22.04
621579
steps:
622580
- name: Download MacOS x64 Artifacts
@@ -708,7 +666,7 @@ jobs:
708666
release:
709667
# NOTE: For now, we only have beta channel to be released on Github
710668
if: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.build-target == 'beta' }}
711-
needs: [ build-macos-x64, build-macos-arm64, build-linux-x64, build-linux-arm64, codesign-windows]
669+
needs: [ build-macos-x64, build-macos-arm64, build-linux-x64, build-linux-arm64]
712670
runs-on: ubuntu-22.04
713671
steps:
714672
- name: Download MacOS x64 Artifacts

0 commit comments

Comments
 (0)