dev: pass html-options from repo-config #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, lets merge it! |
I can support using user defined meta info( head\title...) in next few days. But I have no idea when this PR can be reviewed and merged 😿 |
Who is owner and can merge? @logseq-cldwalker ? Also would be good to have options for add more meta types, and scripts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the underlying export function supports receiving a
html-optionsmap for configurating the published html but it seems that this cli has not supported this feature yet.This PR makes the
publish-spacli read thehrml-optionsfrom the repo config(a.k.alogsq.edn) and enable the user to control the generated html.After logseq/logseq#11149 being merged, user can also define extra scripts they want to include into the published html in their
logseq.edn