Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 3.3.0 relase due failures when publishing gem #71

Merged
merged 5 commits into from
May 5, 2021

Conversation

kares
Copy link
Contributor

@kares kares commented May 4, 2021

The rake task rake vendor did not halt on a ./gradlew vendor failure.
The failure itself was caused by the gradle copy task not specifying a filtering charset,
which lead to sha1sum failures due messing up non-ascii characters e.g.:

393c393
<     family_replacement: 'Seznam prohlížeč'
---
>     family_replacement: 'Seznam prohl????e??'
395c395
<   # Coc Coc browser, based on Chrome (used in Vietnam)
---
>   #??Coc Coc browser, based on Chrome (used in Vietnam)
4305c4305
<   # @ref: www.tecno-mobile.com/‎
---
>   # @ref: www.tecno-mobile.com/???

closing #72
related: elastic/logstash#12869

Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kares kares merged commit 1a56c5b into logstash-plugins:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants