support multiple certificates per file #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvd
force-pushed
the
multi_cert_per_file
branch
from
3e093c8
to
6eb013d
Compare
|
It looks like we have a build failure on 5.x due to a change in behaviour between the activated bouncycastles: |
|
It's a bug in the bouncy castle we ship in 5.6, the fix is in elastic/logstash#10192 |
|
Got it. And we only trigger the bug here, in this scenario that is already broken with the current release of the plugin? If so, then I don't see the harm in shipping as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be tested easily with the following script: https://gist.github.com/jsvd/b8d21abaf103bdfc7fe8b11008070a95
And then set the certificate chain authorities to the concatenation of the RootCA.crt and IntermediateCA.crt:
cat RootCA.crt IntermediateCA.crt > chain.crt