-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Logstash output.elasticsearch index can be alias or datastream #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 howdy, team! Support's noticed some user setup confusion on `index` being able to point to aliases/datastreams and not just indices. This mini expansion helps users understand that "index" used here means "indexing into" which can point to index/alias/datastream. TIA!
mashhurs
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor change requested and LGTM.
Co-authored-by: Mashhur <99575341+mashhurs@users.noreply.github.com>
Published to rubygems.org at v11.22.6 |
stefnestor
added a commit
to elastic/beats
that referenced
this pull request
May 22, 2024
👋 Playing forward logstash-plugins/logstash-output-elasticsearch#1179, our client-side docs think `index` indicates a literal Elasticsearch index when in now this means any ingest target (index, alias, or data stream).
6 tasks
stefnestor
added a commit
to elastic/beats
that referenced
this pull request
May 24, 2024
👋 Playing forward logstash-plugins/logstash-output-elasticsearch#1179, our client-side docs think `index` indicates a literal Elasticsearch index when in now this means any ingest target (index, alias, or data stream).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts with @stefnestor 's work in #1136, and bumps gemspec and changelog version to v.11.22.6