-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to connect to GCS (certificate verify failed) #20
Comments
Thanks for the report @neuromantik33. Sorry if this is a stupid question: are you providing a proper |
I didn't originally since I'm using the default password supplied by google ( |
This plugin was community contributed and is not officially supported by Elastic. I looked at the lib and yeah, it has seen lots of changes and unfortunately it is not a trivial update because the lib APIs have changed too. It is hard to say if the problem is related to the lib version but in any cases upgrading would probably not hurt and should be done at some point. If you are ready to help, I could try and update it and give you instructions on how to test it? let me know if you are willing to help for that! |
I created a PR to use a newer version of the (Java) GCP library to see if that helps. I built and tested the plugin on 6.2.3. Travis is failing for Logstash 5.6 reporting a ruby-maven issue. @colinsurprenant would you be willing to take a look? I'm not that familiar with JRuby and I hope you might have seen this before. |
As a temporary solution, dblommesteijn's solution might work: googleapis/google-api-ruby-client#235 |
Hi. Sorry for the lateness of my reply (French vacations :P).. Anyhow @colinsurprenant @josephlewis42 I would be happy to test out anything you have to give me. I have an environment ready to test and a build pipeline for the logstach docker image w/ gcs-out plugin. |
@neuromantik33 enjoy vacation if you've got it! I've published a gem of the proposed changes I've made in a personal repo: https://github.com/josephlewis42/personal_codebase/releases/tag/logstash-release The caveat is rather than supplying a You should be able to install the plugin using |
@josephlewis42 So I've been testing out your gem and it seems to work great aside from a few annoyances.
Besides that thank you! Hope it gets merged soon! 👍 |
@neuromantik33 sweet, I'm glad things are working well! Let's get this merged in and you can throw them in the backlog (unless either of them are regressions) so one of us can do a smaller PR against them, does that work? @colinsurprenant do you have any hesitations about merging this (#21) and doing a release now that it's been verified? I know there's the outstanding Travis issue but I don't think it's a blocker because it's a known issue. |
Sorry for the delay - @josephlewis42 I did not look into the specifics of the shutdown handling @neuromantik33 is reporting above but I would prefer we make sure that shutdown situations are correctly handled before merging. Let me know if you need help with that, it can be a bit tricky. |
I can do that. I'd like to run the approach by you before coding it up if I can (@neuromantik33 I'd love your feedback too):
@colinsurprenant this plugin suffers from some of that same crazy upload queue/sleep logic the BigQuery one had, I can add an item to my backlog to move this over to a worker pool which should fix #2, #5, and #19 |
@josephlewis42 Sounds good to me, I agree that after browsing the code, an n-thread |
Whoops, I'm confusing my input and my output plugins. The plugin already has a |
@neuromantik33 I got that patch in for testing if you'd like to try it out. I built another gem you can grab from here: https://github.com/josephlewis42/personal_codebase/releases/download/logstash-release/logstash-output-google_cloud_storage-4.0.0-java.gem |
@josephlewis42 After extended testing the plugin works fine under moderate load which is great. A graceful shutdown indeed triggers a last effort upload and deletion, I've tried shutting down filebeat, resuming it, shutting down logstash, killing logstash, all work as expected. The only thing that should be noted although for my use case it isn't a problem is that under docker-compose (my initial tests before Kubernetes), when stopping the logstash container using Again this is a extremely small issue, as when stopping pods |
@neuromantik33 awesome! I just opened up #23 as a potential fix for the clobber, I'd love your input if you have time. |
This change removes support for the legacy PKCS GCP authentication key format in favor of ADC or JSON keys. In the process of upgrading the plugin got an overhaul to use the Java GCP libraries which will improve stability and platform compatibility. Fixes #20
I'm unable to use with plugin within a docker container, using the
6.1.0
and5.6.8
tags. I'm pretty sure it isn't the key since I've generated 3 different p12 keys for the same service account and they all fail, and the stacktrace fails beforehand.Here is my configuration (I've changed all bucket names and project ids for obvious reasons) :
v3.0.4
docker.elastic.co/logstash/logstash:6.1.0
logstash.yml
:logstash.conf
:As I said it doesn't seem to be a p12 key issue (that line is never reached) but some other odd behviour. Is this plugin still supported with Google Cloud's current storage API, or even logstash 5.x or 6.x for that matter. Any help would be much appreciated (which may include alternatives for shipping filebeat logs to GCS)
Thanks in advance
The text was updated successfully, but these errors were encountered: