Send GlobalContext.Properties and MachineName:ProcessId #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possibility to specify (statically and dynamically) fields which should be taken from 'GlobalContext.Properties'.
yellowblood
reviewed
Jan 13, 2017
| @@ -38,14 +42,30 @@ private void WriteImpl(LoggingEvent loggingEvent) | |||
| {"thread", loggingEvent.ThreadName}, | |||
| {"message", loggingEvent.RenderedMessage}, | |||
| {"exception", loggingEvent.GetExceptionString()}, | |||
| {"user", loggingEvent.UserName}, | |||
| // log4net already adds this 'username' property which is added to values bellow | |||
| key = key.Replace(":", ""); | ||
| key = key.Replace(".", ""); | ||
| key = key.Replace("log4net", ""); | ||
| values["property" + key] = value; |
There was a problem hiding this comment.
why the property prefix? do you think the "key" string would collide with other fields?
There was a problem hiding this comment.
Well.. collision is possible. I thought would be nice to have a clear separation of these properties. On the other hand its not really needed and can be without 'property' prefix. In some cases it is even more nice instead of 'propertyIdentity' to have 'Identity'. So I leave it for you to make final decision here.
There was a problem hiding this comment.
Hey, I did some major changes, including support for objects (non-string) in fields. You may grab the last revision if you want, or wait until I'll finish with the other improvements and release an official version. Thank you.
idohalevi
added a commit
that referenced
this pull request
Feb 24, 2019
* merge SerializeLogEvents* to one function *change MediaTypeHeaderValue to application/json
idohalevi
pushed a commit
that referenced
this pull request
Feb 24, 2019
* add gzip Compression * Add Compression option to ship the logs, by default this option is on false, need to add this option to the documentation. * fix HttpClientHandler to work with "application/jso" * * clean unused imports (#1) * merge SerializeLogEvents* to one function *change MediaTypeHeaderValue to application/json * delete compression in sanity test (#2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibility to specify (statically and dynamically) fields which should be taken from 'GlobalContext.Properties'.