Conversion to Netstandard 2.0 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing framework config and AssemblyInfo files which are not needed for dotnet standard. Tests are using the shouldly extension to perform assertions between values. Fixing up some inconsistent formatting. In addition updated const usage.
Stop using shouldBeSameAs as we don't need reference checking for comparing values.
… using assembly to reference the logger for log4net. Remove usage of should match as Shouldly.ShouldContain works without using a pseudo regex. Found instability in ShipperTests.Ship_BufferTimeoutReached_LogWasSent where too quick execution can trigger an error.
|
The travis.yml is targeting .Net Framework. |
|
Hey, Thanks for the contribution. Unfortunately I no longer work at logz.io , so you better contact their support and ask if they can merge this PR. I'd check if the build scripts are still able to create the packages for .NET 4 and 4.5, and add a build script for core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commits are converting the project to be based on .Net Standard 2.0. The tests are based on .Net Core 2.0 to still be supporting NUnit correctly.