Improve package versioning to resolve #7 #10
Conversation
|
I guess we shouldnt allow bump2version to tag for us since we create the tag via https://github.com/loicleyendecker/deeppath/releases/new ? |
1 similar comment
|
I guess we shouldnt allow bump2version to tag for us since we create the tag via https://github.com/loicleyendecker/deeppath/releases/new ? |
1Mark
force-pushed
the
fix-versioning
branch
2 times, most recently
from
1ca3b7a
to
639285b
Compare
|
Have a look at https://github.com/1Mark/deeppath/runs/5523775597?check_suite_focus=true |
- Add automatic version bumping when a new release is created via https://github.com/loicleyendecker/deeppath/releases/new - tag name must be semver and follow va.b.c - move bump2version config from setup.cfg to .bumpversion.cfg since it will delete any comments in the cfg files see c4urself/bump2version#37
| [bumpversion] | ||
| current_version = 0.1.4 | ||
| commit = True | ||
|
|
There was a problem hiding this comment.
Intentionally dont tag since we will do this via https://github.com/loicleyendecker/deeppath/releases/new
| bump2version --new-version ${GITHUB_REF_NAME#v} minor | ||
| # must supply either patch minor or major see https://github.com/c4urself/bump2version/issues/244 | ||
| # but it's an ignored argument argument | ||
| git show |
There was a problem hiding this comment.
We also need a step to perform a git push at the very end - after pypi upload is successful - but being in a detached head mode in the CI is proving an issue. Going to park this for now :(
https://github.com/loicleyendecker/deeppath/releases/new
since it will delete any comments in the cfg files
see bump2version deletes comments/commented out lines when using setup.cfg c4urself/bump2version#37