Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecordProcessor Warning on NULL FormIDs #6

Open
lojack5 opened this issue Jun 8, 2014 · 0 comments
Open

RecordProcessor Warning on NULL FormIDs #6

lojack5 opened this issue Jun 8, 2014 · 0 comments

Comments

@lojack5
Copy link
Owner

lojack5 commented Jun 8, 2014

Brought up originally here: wrye-bash/wrye-bash#101

Essentially, it's possible for NULL FormIDs to get passed to various RecordProcessors if they exist in some of the sub-records. Sometimes, it's OK for there to be a NULL FormID there, sometimes it's not, but the current workings of the class don't allow for checking of the information, or even reporting which record had the NULL FormID in one of its sub-records.

The first bit can be solved with smarter passing of FormIDs to op.Accept, the second will require refactoring so RecordProcessor can have the information needed to display a better warning message.

As it is currently, most cases can be safely ignored, and it just leads to confusion.

lojack5 pushed a commit that referenced this issue Jun 17, 2014
This will break the CMake config. Part of issue #6 work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant