Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve instantiation of bugsnag and newrelic plugins #8

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Improve instantiation of bugsnag and newrelic plugins #8

merged 1 commit into from
Jan 2, 2023

Conversation

kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jan 2, 2023 •
edited
Loading

Changes

Lazy-instantiate newrelic to avoid it throwing a gajillion of errors during integration tests
Add isEnabled flag for bugsnag

Checklist

  • Apply one of following labels; major, minor, patch or skip-release

@kibertoad kibertoad added the major label Jan 2, 2023
@kibertoad kibertoad merged commit 7127180 into main Jan 2, 2023
@kibertoad kibertoad deleted the fix/improve-plugin-init branch January 2, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokankr lokankr lokankr approved these changes

@rupert-mckay rupert-mckay Awaiting requested review from rupert-mckay

@drdaemos drdaemos Awaiting requested review from drdaemos drdaemos is a code owner

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kibertoad @lokankr