Array remove nullish #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Oct 17, 2023
CarlosGamero
commented
Oct 17, 2023
src/utils/arrayUtils.ts
Outdated
Comment on lines
29
to
41
| /** | ||
| * Return a copy of the given array without null or undefined values | ||
| */ | ||
| export function removeNullish<T>(array: readonly (T | null | undefined)[]): T[] { | ||
| return array.filter((e) => e !== undefined && e !== null) as T[] | ||
| } | ||
|
|
||
| /** | ||
| * Return a copy of the given array without falsy values (eg: false, 0, '', null, undefined) | ||
| */ | ||
| export function removeFalsy<T>(array: readonly (T | null | undefined)[]): T[] { | ||
| return array.filter((e) => e) as T[] | ||
| } |
There was a problem hiding this comment.
Finally, I added both because I can think of use cases where both can be useful, but feel free to disagree
There was a problem hiding this comment.
I think that's a great call!
kibertoad
reviewed
Oct 17, 2023
CarlosGamero
requested review from
rupert-mckay,
lokankr,
drdaemos,
andris-sevcenko and
ForterLokalise
as code owners
kibertoad
reviewed
Oct 17, 2023
Co-authored-by: Igor Savin <iselwin@gmail.com>
kibertoad
reviewed
Oct 17, 2023
Co-authored-by: Igor Savin <iselwin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding
removeNullishandremoveFalsyto facilitate array cleaningChecklist
major,minor,patchorskip-release