Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert date fields to iso string array handling #80

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Convert date fields to iso string array handling #80

merged 4 commits into from
Nov 17, 2023

Conversation

CarlosGamero
Copy link
Contributor

@CarlosGamero CarlosGamero commented Nov 16, 2023 •
edited
Loading

Changes

Fixing an issue on convertDateFieldsToIsoString, which produces that arrays of simple types (number, string ...) to not be converted properly

Checklist

  • Apply one of following labels; major, minor, patch or skip-release
  • I've updated the documentation, or no changes were necessary
  • I've updated the tests, or no changes were necessary

@CarlosGamero CarlosGamero added bug Something isn't working patch labels Nov 16, 2023
@CarlosGamero CarlosGamero self-assigned this Nov 16, 2023
@CarlosGamero CarlosGamero marked this pull request as ready for review November 17, 2023 08:43
@CarlosGamero CarlosGamero mentioned this pull request Nov 17, 2023
Merged
3 tasks
@CarlosGamero CarlosGamero merged commit 2b32b15 into main Nov 17, 2023
5 checks passed
@CarlosGamero CarlosGamero deleted the bugfix/convertDateFieldsToIsoString_array_handling branch November 17, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdaemos drdaemos drdaemos approved these changes

@kibertoad kibertoad Awaiting requested review from kibertoad kibertoad is a code owner

@rupert-mckay rupert-mckay Awaiting requested review from rupert-mckay

@lokankr lokankr Awaiting requested review from lokankr

@andris-sevcenko andris-sevcenko Awaiting requested review from andris-sevcenko

@ForterLokalise ForterLokalise Awaiting requested review from ForterLokalise

Assignees

@CarlosGamero CarlosGamero

Labels
bug Something isn't working patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarlosGamero @drdaemos