Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected click event when works with select2 #14

Closed
vikyd opened this issue Aug 24, 2017 · 4 comments
Closed

unexpected click event when works with select2 #14

vikyd opened this issue Aug 24, 2017 · 4 comments

Comments

@vikyd
Copy link

vikyd commented Aug 24, 2017

https://jsfiddle.net/2j5gx35j/11/

When working with Select2 , if dropdown list of select2 cover pretty-checkbox, after click select2 item, will also cause pretty-checkbox seleted.

May this two css rules is the reason:

z-index: 99999999;: https://github.com/lokesh-coder/pretty-checkbox/blob/master/src/pretty.css#L63

opacity: 0;: https://github.com/lokesh-coder/pretty-checkbox/blob/master/src/pretty.css#L71

@lokesh-coder
Copy link
Owner

Hi @Viky-zhang ,
Thanks for pointing out the issue and providing the jsfiddle.
Let me fix this and update the repo.

@vikyd
Copy link
Author

vikyd commented Sep 14, 2017

@lokesh-coder
Is already fixed now ?

lokesh-coder added a commit that referenced this issue Oct 21, 2017
…e calculated from parent font size. Aligned to baseline of the application's font.

BREAKING CHANGE: The complete API has been changed, and this version does not compatible with v2.x

refactor( core ): Complete rewritten of the library
feat( animation ): Pulse
feat( state ): Introducing state, to work with different checkbox states
feat( scale ): Added support to make checkbox bigger
feat( SVG ): Added support for svg elements,files and sprites
feat( Image ): Added support for tiny images
feat( Switch ): New iOS style switches with 3 variants
fix( core ): z-index is calculated from 0 to 2 [ #6 , #14  ]
feat( lock ): Similar to disable but looks like active [ #17  ]
build( CI ): Setup Travis for auto publish from staging to master 
doc( readme ): Updated with examples, badges, gif preview and a logo
doc( readme ): Removed bower installation guide
doc( readme ): Changed CDN provider from cdnjs to jsDelivr
refactor( core ): All class names starts with prefix `p-` except *pretty*and *state*
lokesh-coder added a commit that referenced this issue Oct 21, 2017
…e calculated from parent font size. Aligned to baseline of the application's font. (#19)

BREAKING CHANGE: The complete API has been changed, and this version does not compatible with v2.x

refactor( core ): Complete rewritten of the library
feat( animation ): Pulse
feat( state ): Introducing state, to work with different checkbox states
feat( scale ): Added support to make checkbox bigger
feat( SVG ): Added support for svg elements,files and sprites
feat( Image ): Added support for tiny images
feat( Switch ): New iOS style switches with 3 variants
fix( core ): z-index is calculated from 0 to 2 [ #6 , #14  ]
feat( lock ): Similar to disable but looks like active [ #17  ]
build( CI ): Setup Travis for auto publish from staging to master 
doc( readme ): Updated with examples, badges, gif preview and a logo
doc( readme ): Removed bower installation guide
doc( readme ): Changed CDN provider from cdnjs to jsDelivr
refactor( core ): All class names starts with prefix `p-` except *pretty*and *state*
@lokesh-coder
Copy link
Owner

Hi @Viky-zhang ,

The issue has been fixed in new version 3. The z-index has few more problems ( like #6 ) and side effects, So the code is completely changed with no backward compatibility.

I have updated your jsfiddle code with new version.
https://jsfiddle.net/31gysmen/

Here's the documentation.

Thanks!

@lokesh-coder
Copy link
Owner

Closing due to inactivity. Please reopen if you still face the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants