Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Enable target attribute in caption links #299

Merged
merged 1 commit into from
Jun 15, 2015

Conversation

janmuennich
Copy link

With this fix it's possible to open caption links in a new tab/window with target="_blank"

@rulin132
Copy link

I've tested this using the latest PC version of Chrome, Firefox and IE 11 - 8 and seems to work fine.

Would be nice to see this patch pulled into the Lokesh/lightbox2 repository, in the meantime, I might use this myself.

@freepius
Copy link

Hi @lokesh ! Is it possible to apply this very useful patch ?
Thanks a lot.

lokesh added a commit that referenced this pull request Jun 15, 2015
Fix: Enable target attribute in caption links
@lokesh lokesh merged commit 556a152 into lokesh:master Jun 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants