Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment in medpy.metric.binary.hd regarding connectivity is not correct #25

Closed
joseabernal opened this issue Apr 18, 2017 · 3 comments
Closed
Assignees
Milestone

Comments

@joseabernal
Copy link

"connectivity : int
The neighbourhood/connectivity considered when determining the surface of the binary objects. This value is passed to scipy.ndimage.morphology.generate_binary_structure and should usually be >1>1. Presumably does not influence the result in the case of the Hausdorff distance."
I have tested in 3D objects and it actually has a big influence in the result.

@loli loli self-assigned this Apr 23, 2017
@loli loli added this to the MedPy 0.3.0 milestone Apr 23, 2017
@loli
Copy link
Owner

loli commented Apr 23, 2017

Thank you for the comment. I just took a short look at the code and the connectivity should not affect the HD distance, as far as I can tell. Will search for the problem before releasing the new version.

@joseabernal
Copy link
Author

joseabernal commented May 12, 2017

The calculation of the border depends on the connectivity.

"result_border = result - binary_erosion(result, structure=footprint, iterations=1)
reference_border = reference - binary_erosion(reference, structure=footprint, iterations=1)"

loli added a commit that referenced this issue Aug 9, 2017
Corrected a false statement in the function description of hd() according to issue #25
@loli
Copy link
Owner

loli commented Aug 9, 2017

Fixed with commit 7d52b40

@loli loli closed this as completed Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants