run tests in ci #59
Merged
run tests in ci #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cancan101
force-pushed
the
enable_tests
branch
from
917eeaa
to
464da71
Compare
|
Yes... the tests are still an issue... :/ |
|
Subset of tests actually do pass on 2.7 and I think the same subset should also pass on 3.5+ once the python3 PR is merged. |
cancan101
force-pushed
the
cancan101-patch-1
branch
from
5be7660
to
0992ab3
Compare
cancan101
force-pushed
the
enable_tests
branch
from
7fa04f9
to
22cd241
Compare
cancan101
force-pushed
the
cancan101-patch-1
branch
from
0992ab3
to
749a232
Compare
cancan101
force-pushed
the
enable_tests
branch
from
22cd241
to
b27cd84
Compare
cancan101
force-pushed
the
cancan101-patch-1
branch
from
749a232
to
8739d25
Compare
cancan101
force-pushed
the
enable_tests
branch
from
b27cd84
to
d689acf
Compare
|
@loli tests now passing. I had to add an eps to some code for python3 compat in round calls. |
|
ping |
loli
reviewed
Apr 7, 2018
medpy/filter/houghtransform.py
Outdated
| @@ -192,7 +193,8 @@ def template_ellipsoid (shape): | |||
| A boolean array containing an ellipsoid. | |||
| """ | |||
| # prepare template array | |||
| template = numpy.zeros([int(round(x / 2.)) for x in shape], dtype=numpy.bool) # in odd shape cases, this will include the ellipses middle line, otherwise not | |||
| # we add eps to keep old rounding up behavior | |||
| template = numpy.zeros([int(round(x / 2. + 1e-9)) for x in shape], dtype=numpy.bool) # in odd shape cases, this will include the ellipses middle line, otherwise not | |||
There was a problem hiding this comment.
This feels a little bit hackish to me. I assume you added the eps to account for the differences in P2 and P3 round() behaviour (banker's rounding vs. to nearest even)?
I think a more elegant solution to the P2 rounding behaviour in P3 would be:
import decimal
decimal.Decimal(x / 2.).quantize(decimal.Decimal('1'), rounding=decimal.ROUND_HALF_UP)
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #58 (cleanup build matrix)Depends on #60 (python 3)