Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when there's no db changes, no need to call into auto_schema a second time #461

Merged
merged 1 commit into from
Sep 4, 2021
Merged

when there's no db changes, no need to call into auto_schema a second time #461

merged 1 commit into from
Sep 4, 2021

Commits on Sep 3, 2021

  1. when there's no db changes, no need to call into auto_schema a second… 

    … time

both paths are running the same code
https://github.com/lolopinto/ent/blob/main/python/auto_schema/auto_schema/runner.py#L185
https://github.com/lolopinto/ent/blob/main/python/auto_schema/auto_schema/runner.py#L258

so no reason to call this twice.

we just keep a flag in golang that we check and avoid the overhead a second time

way simpler than options presented at #453
    @lolopinto
    lolopinto committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    cdd8ccd View commit details
    Browse the repository at this point in the history