Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placing evac zone intermittently seems to crash the game #38

Closed
pledbrook opened this issue Mar 12, 2019 · 16 comments
Closed

Placing evac zone intermittently seems to crash the game #38

pledbrook opened this issue Mar 12, 2019 · 16 comments
Labels
blocker Must be fixed before initial release bug Something isn't working
Milestone

Comments

@pledbrook
Copy link
Collaborator

I don't know whether this is dependent on which soldier does it, or whether it's from a previously saved game, or what. But this is game breaking.

@pledbrook pledbrook added bug Something isn't working blocker Must be fixed before initial release labels Mar 12, 2019
@Tylon01
Copy link

Tylon01 commented Apr 8, 2019

EvacBug.zip
So far in my testing I have been able to reproduce this on two occasions.

If the evac flare is thrown as the first action it is able to be correctly placed and acts as expected. If you try to place the evac flare after the first characters actions such as at turn end, the game client reliably crashes each time.

I have two saved games where this can be reproduced. both are included in the zip file

@pledbrook
Copy link
Collaborator Author

I managed to reproduce the first time, then ran it through the debugger. Haven't managed to reproduce since 😢 I may have to try reproducing with new missions each time. Unfortunately, I don't have an inkling what the trigger conditions are.

@pledbrook pledbrook added this to the 1.6-alpha-2 milestone Apr 9, 2019
@pledbrook
Copy link
Collaborator Author

I think I may have a fix for this. It's hard to be sure considering the trouble I've had with reproducing the bug, but I'm 80% confident. We'll have to see once alpha 2 is out and people are testing it. (No config fix this time, unfortunately)

pledbrook added a commit that referenced this issue Apr 9, 2019
I've moved a `GetEvacPlacementDelay` event listener function from
LWListenerManager to a dedicated `X2EventListener_Tactical` class.
This seems to have fixed the issue.
@pledbrook
Copy link
Collaborator Author

This should be reopened if the fix doesn't actually fix the problem.

@pledbrook
Copy link
Collaborator Author

This is clearly not fixed, unfortunately.

@pledbrook pledbrook reopened this Apr 14, 2019
@ansabalirai
Copy link
Contributor

So, I thought this was maybe dependent on a particular soldier throwing evac or if it is thrown in a particular turn. However, it is seemingly completely random and very hard to reproduce, but it is happening frequently enough to be an annoyance.

@aondiar
Copy link

aondiar commented Apr 19, 2019

Had this happen to me twice. Both time it was using a faction soldier (Reaper, Skirmisher) as the first action of the turn.

@jmartinez989
Copy link
Contributor

So at this point this seems almost random. I have gotten this with just about any soldier type and didn't matter if it was the first or last action of the turn.

Only way I have been consistently able to avoid this is to save and then load before placing evac.

@The13Inquisitor
Copy link

So, any progress with this bug?

I've presently got a mission I've been stuck on for a while whenever I try and throw an evac flare.

It's a destroy a relay mission on an underground map, which I'd argue extractions on that map type ought to have a fixed evac zone anyway, a la Lost and Abandoned for thematic reasons.

I mean, it's not like you can very well go and expect an aerial extraction underground, unless Advent's knocked a hole in the roof for you.

@pledbrook
Copy link
Collaborator Author

Nope, sorry. I can't reproduce it myself and some new logging hasn't clarified why this is sometimes happening. If you have a save file that reproduces the problem, please attach it here and I'll try it.

@pledbrook
Copy link
Collaborator Author

Has anyone noticed whether this is happening for any soldiers other than specialists?

@The13Inquisitor
Copy link

Well, it's happened with the Rookies in this particular mission, although I've got to wonder whether the map type has anything to do with it.

Also, where exactly ought I look for the saves? I'm going through now and can't seem to find them.

@pledbrook
Copy link
Collaborator Author

pledbrook commented May 25, 2019

Documents\My Games\XCOM2 War of the Chosen\XComGame\SaveData

@The13Inquisitor
Copy link

Thanks. Now I'm getting an unsupported file type message though.

@pledbrook
Copy link
Collaborator Author

When you're trying to attach it to this issue? If so, that's because you need to zip the save file before uploading it.

@The13Inquisitor
Copy link

Ah. Okay. That should do it then.
save_AUTOSAVE- Campaign 61, Mission 2_1.zip

pledbrook added a commit that referenced this issue May 25, 2019
It seems that the code in `UIScreenListener_TacticalHUD` that was updating
the UI timer for the evac counter was running on the game state thread,
which it shouldn't be doing in WOTC. Changing the listener registration that
invokes the code to `ELD_OnVisualizationBlockStarted` seems to have fixed
the issue (fingers crossed).
@pledbrook pledbrook modified the milestones: 1.6-alpha-2, 1.6-alpha-3 May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Must be fixed before initial release bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants