Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n icelandic causes build issues #30

Closed
gardyna opened this issue Dec 11, 2018 · 6 comments
Closed

i18n icelandic causes build issues #30

gardyna opened this issue Dec 11, 2018 · 6 comments

Comments

@gardyna
Copy link

gardyna commented Dec 11, 2018

From @zoechi on December 11, 2018 18:6

@gardyna commented on Tue Dec 11 2018

adding Icelandic to internationalization creates the class "is" in i18n.dart which conflicts with a reserved keyword an causes any build to fail. I suggest changing it to isl (if possible) to avoid name conflicts or making some "default addition" to class names in i18n like and underscore or "lang_" to avoid future name confilct in i18n.


@zoechi commented on Tue Dec 11 2018

Where does the i18n.dart file come from? What method of adding i18n are you referring to?


@gardyna commented on Tue Dec 11 2018

When opening the project in android studio on mac I was prompted whether I wanted to add internationalization to the project. I clicked "yes" which added "res/values/strings_en.arb" and "lib/generated/i18n.dart" and get the suggestion to extract string resource. That wizard also allows me to add languages/regions. after finding Icelandic and adding it "res/values/strings_is.arb" appears along with additional code in i18n.dart (which causes the error)

attached is image of the wizard. I was under the assumption that this was an official addition to the dev-kit
image


@zoechi commented on Tue Dec 11 2018

@gardyna thanks for the update. I never used this assistant and wasn't aware of this feature.

Copied from original issue: flutter/flutter-intellij#2945

@gardyna
Copy link
Author

gardyna commented Dec 11, 2018

From @zoechi on December 11, 2018 18:7

Just a wild guess that this is a plugin feature.
Let's move back to flutter/flutter if this is not related to the Flutter plugin.

@gardyna
Copy link
Author

gardyna commented Dec 11, 2018

it appears to be this pluggin which causes the issue.

@long1eu
Copy link
Owner

long1eu commented Dec 14, 2018

hi! good catch

long1eu added a commit that referenced this issue Dec 14, 2018
* add string key inspection
@long1eu
Copy link
Owner

long1eu commented Dec 15, 2018

let me know if the issue is still present in the new version

@long1eu long1eu closed this as completed Dec 15, 2018
@gardyna
Copy link
Author

gardyna commented Dec 22, 2018

Did a build this morning with Icelandic (and several other languages) everything went off without a hitch and is functioning perfectly, thank you for the quick fix.

@long1eu
Copy link
Owner

long1eu commented Dec 22, 2018

Nice to hear that it work for you. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants