-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n icelandic causes build issues #30
Comments
From @zoechi on December 11, 2018 18:7 Just a wild guess that this is a plugin feature. |
it appears to be this pluggin which causes the issue. |
hi! good catch |
let me know if the issue is still present in the new version |
Did a build this morning with Icelandic (and several other languages) everything went off without a hitch and is functioning perfectly, thank you for the quick fix. |
Nice to hear that it work for you. :D |
From @zoechi on December 11, 2018 18:6
@gardyna commented on Tue Dec 11 2018
adding Icelandic to internationalization creates the class "is" in i18n.dart which conflicts with a reserved keyword an causes any build to fail. I suggest changing it to isl (if possible) to avoid name conflicts or making some "default addition" to class names in i18n like and underscore or "lang_" to avoid future name confilct in i18n.
@zoechi commented on Tue Dec 11 2018
Where does the
i18n.dart
file come from? What method of adding i18n are you referring to?@gardyna commented on Tue Dec 11 2018
When opening the project in android studio on mac I was prompted whether I wanted to add internationalization to the project. I clicked "yes" which added "res/values/strings_en.arb" and "lib/generated/i18n.dart" and get the suggestion to extract string resource. That wizard also allows me to add languages/regions. after finding Icelandic and adding it "res/values/strings_is.arb" appears along with additional code in i18n.dart (which causes the error)
attached is image of the wizard. I was under the assumption that this was an official addition to the dev-kit
@zoechi commented on Tue Dec 11 2018
@gardyna thanks for the update. I never used this assistant and wasn't aware of this feature.
Copied from original issue: flutter/flutter-intellij#2945
The text was updated successfully, but these errors were encountered: