Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changeable_budget compatibility #1455

Closed
lmoureaux opened this issue Nov 4, 2022 · 0 comments · Fixed by #1468
Closed

changeable_budget compatibility #1455

lmoureaux opened this issue Nov 4, 2022 · 0 comments · Fixed by #1468
Labels
bug Something isn't working spec-file Related to Rulesets, Tilesets, Musicsets, Soundsets, etc.

Comments

@lmoureaux
Copy link
Contributor

lmoureaux commented Nov 4, 2022

Is your feature request related to a problem? Please describe.

In #1404, the changable_tax ruleset parameter (in cities.ruleset) to changable_budget. This changed the ruleset format in an incompatible way. Moreover, the spelling is incorrect and should be changeable.

Describe the solution you'd like

  • Accept changable_tax, but emit a warning that it's deprecated.
  • Rename changable_budget to changeable_budget. While this is another format change, I think it's an acceptable tradeoff because changable_budget was only present for a short time.

The new syntax should be preferred over the old one.

Describe alternatives you've considered

Also introducing a fallback for changable_budget. I don't think it's necessary.

Additional context

@jwrober tried to load Aviation in pyciv, which cares about this kind of errors (unlike the main game).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spec-file Related to Rulesets, Tilesets, Musicsets, Soundsets, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant