Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client shows "castle" for units inside city when no units are in the city #437

Closed
jwrober opened this issue Apr 16, 2021 · 1 comment · Fixed by #668
Closed

Client shows "castle" for units inside city when no units are in the city #437

jwrober opened this issue Apr 16, 2021 · 1 comment · Fixed by #668
Labels
bug Something isn't working

Comments

@jwrober
Copy link
Collaborator

jwrober commented Apr 16, 2021

See screenshot. Would expect the flag to not be adorned.

image
@lmoureaux lmoureaux added the bug Something isn't working label Apr 18, 2021
@lmoureaux
Copy link
Contributor

I can reproduce.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Sep 26, 2021
@lmoureaux
Only show the occupied icon for occupied cities
d06db8a 
When using citybar style "simple", the "city is occupied" icon was always
shown. Only show it when the city is actually occupied.

Closes longturn#437.
@lmoureaux lmoureaux mentioned this issue Sep 26, 2021
Merged
lmoureaux added a commit that referenced this issue Sep 26, 2021
@lmoureaux
Only show the occupied icon for occupied cities
c619808 
When using citybar style "simple", the "city is occupied" icon was always
shown. Only show it when the city is actually occupied.

Closes #437.
psampathkumar pushed a commit to psampathkumar/freeciv21 that referenced this issue Nov 14, 2021
@lmoureaux @psampathkumar
Only show the occupied icon for occupied cities
27fa8b9 
When using citybar style "simple", the "city is occupied" icon was always
shown. Only show it when the city is actually occupied.

Closes longturn#437.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only show the occupied icon for occupied cities lmoureaux/freeciv21
2 participants
@lmoureaux @jwrober