Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't scale city-bar flags with Map Zoom #686

Closed
HansLemurson opened this issue Oct 14, 2021 · 2 comments · Fixed by #690
Closed

Don't scale city-bar flags with Map Zoom #686

HansLemurson opened this issue Oct 14, 2021 · 2 comments · Fixed by #690
Assignees
Labels
enhancement New feature or request gui This issue requires changes to the user interface

Comments

@HansLemurson
Copy link

Is your feature request related to a problem? Please describe.
When using the + and - keys to shrink or enlarge the tiles of the map (very useful), the city-bar grows and shrinks with the rest of the map. This makes the city-bars take up too much screen area and become a nuisance.
Fortunately, there's an option in the "View" menu for "scale fonts", that can be un-checked to prevent the text-size from growing.
Unfortunately, the city-bar enlarges anyways, because the flag graphics within it shrinks and grows with the map.
image

Describe the solution you'd like
I would like the city-bar to remain a constant size while the map is shrunk or enlarged behind it.
Maybe have that be controlled by the "scale fonts" checkbox. Just rename it to

Describe alternatives you've considered
Suffering silently.

Additional context
The problem seems to be related with all tileset graphics being shrunk or enlarged, regardless of whether the graphics are for the UI or the Map. Is there a way to deal with graphics used in the city-bar UI separately?
The graphics in the city-view itself seem to be immune to the changes, so that's good.

@HansLemurson HansLemurson added enhancement New feature or request Untriaged This issue or PR needs triaging labels Oct 14, 2021
@lmoureaux lmoureaux added gui This issue requires changes to the user interface and removed Untriaged This issue or PR needs triaging labels Oct 14, 2021
@lmoureaux lmoureaux self-assigned this Oct 15, 2021
@lmoureaux
Copy link
Contributor

Is this what you suggest?
image

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Oct 15, 2021
This will allow using it outside of gui-qt and removes some clutter from
"king".

See longturn#686.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Oct 15, 2021
When zooming in, it looks better if they keep consistent sizes.

Closes longturn#686.
@HansLemurson
Copy link
Author

Is this what you suggest? image

Beautiful! Now my only concern is that the gigantic whale will devour us all.

@lmoureaux lmoureaux linked a pull request Oct 16, 2021 that will close this issue
lmoureaux added a commit that referenced this issue Oct 27, 2021
This will allow using it outside of gui-qt and removes some clutter from
"king".

See #686.
lmoureaux added a commit that referenced this issue Oct 27, 2021
When zooming in, it looks better if they keep consistent sizes.

Closes #686.
psampathkumar pushed a commit to psampathkumar/freeciv21 that referenced this issue Nov 14, 2021
This will allow using it outside of gui-qt and removes some clutter from
"king".

See longturn#686.
psampathkumar pushed a commit to psampathkumar/freeciv21 that referenced this issue Nov 14, 2021
When zooming in, it looks better if they keep consistent sizes.

Closes longturn#686.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gui This issue requires changes to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants