Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on Unit in "Unit Bar" at bottom of screen opens City window when overlapping #687

Closed
jwrober opened this issue Oct 15, 2021 · 1 comment · Fixed by #689
Closed

Clicking on Unit in "Unit Bar" at bottom of screen opens City window when overlapping #687

jwrober opened this issue Oct 15, 2021 · 1 comment · Fixed by #689
Assignees
@lmoureaux
Labels
bug Something isn't working gui This issue requires changes to the user interface

Comments

@jwrober
Copy link
Collaborator

jwrober commented Oct 15, 2021

Describe the bug
If the Unit action bar at the bottom of the screen overlaps a city on the map and you click on unit to center it on the map, the city window will pop up instead.

To Reproduce
Steps to reproduce the behavior:

  1. Notice a unit is active and shown in the unit action bar at the bottom of the screen (see screen shot) and also notice that the unit bar overlaps a bit of a city.
  2. Click on the in the unit action bar to attempt to center the unit on the screen.
  3. The screen will attempt to center on the unit and then will instead open the city window.

Expected behavior
Because the city is "behind" the unit action bar, I would expect to have the unit centered on the screen and ignore the city.

Screenshots
image

Platform and version (please complete the following information):

  • OS: Linux
  • Freeciv21 version: 3.0-alpha8+
  • Ruleset/Longturn game (if applicable): Classic

Additional context
None
@jwrober jwrober added bug Something isn't working Untriaged This issue or PR needs triaging gui This issue requires changes to the user interface labels Oct 15, 2021
@lmoureaux lmoureaux removed the Untriaged This issue or PR needs triaging label Oct 15, 2021
@lmoureaux
Copy link
Contributor

Related to #566

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Oct 15, 2021
@lmoureaux
Prevent clicking on HUD widgets from acting on the map
b91bd2e 
Clicking on a widget displayed on top of the map was sometimes triggering
actions as if the map had been clicked underneath. Prevent this by disabling
the propagation of mouse events to the parent widget.

Closes longturn#687.
Closes longturn#566.
@lmoureaux lmoureaux mentioned this issue Oct 15, 2021
Merged
@lmoureaux lmoureaux self-assigned this Oct 16, 2021
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Oct 17, 2021
@lmoureaux
Prevent clicking on HUD widgets from acting on the map
889a5ec 
Clicking on a widget displayed on top of the map was sometimes triggering
actions as if the map had been clicked underneath. Prevent this by disabling
the propagation of mouse events to the parent widget.

Closes longturn#687.
lmoureaux added a commit that referenced this issue Oct 27, 2021
@lmoureaux
Prevent clicking on HUD widgets from acting on the map
3993b91 
Clicking on a widget displayed on top of the map was sometimes triggering
actions as if the map had been clicked underneath. Prevent this by disabling
the propagation of mouse events to the parent widget.

Closes #687.
psampathkumar pushed a commit to psampathkumar/freeciv21 that referenced this issue Nov 14, 2021
@lmoureaux @psampathkumar
Prevent clicking on HUD widgets from acting on the map
0d0b809 
Clicking on a widget displayed on top of the map was sometimes triggering
actions as if the map had been clicked underneath. Prevent this by disabling
the propagation of mouse events to the parent widget.

Closes longturn#687.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmoureaux lmoureaux

Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent clicking on HUD widgets from acting on the map lmoureaux/freeciv21
2 participants
@lmoureaux @jwrober