Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Allies Only button #1706

Merged
merged 3 commits into from
Jan 7, 2023

Conversation

lmoureaux
Copy link
Contributor

Use a dropdown menu and improve styling.

Closes #1646.

@lmoureaux lmoureaux requested a review from jwrober January 6, 2023 04:03
Having the two options described as text clears out the meaning without the
need to look at a hidden tooltip.

See longturn#1646.
I would have preferred to see a check mark next to the icon, but this is not
possible with stylesheets. Added for the "Allies Only" menu.

See longturn#1646.
Buttons were hardly visible and text was black-on-black. Improve contrast. The
move widget (the arrow at the top left) was reluctant to changing its color so
I momentarily gave up.
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwrober jwrober merged commit e4799e2 into longturn:master Jan 7, 2023
@lmoureaux lmoureaux deleted the bugfix/allies-only-setting branch January 7, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allies only vs public chat button still not intuitive
2 participants