Fix saving hexagonal maps to image #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculated image size was never exactly matched by a renderer update, resulting in the image never being saved. The stall temporary renderer was then blocking map updates. Only require the renderer update to be larger than the calculated size, which will always happen since we trigger a full update. In addition, remove wrong size heuristics for iso-hex tilesets: they behave just like normal isometric tilesets. Closes longturn#1642.
jwrober
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculated image size was never exactly matched by a renderer update, resulting in the image never being saved. The stall temporary renderer was then blocking map updates. Only require the renderer update to be larger than the calculated size, which will always happen since we trigger a full update.
In addition, remove wrong size heuristics for iso-hex tilesets: they behave just like normal isometric tilesets.
Closes #1642.
Backport candidate since this ended up being a relatively easy fix.