Remove unused IS_BETA_VERSION and related functions #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs |
|
Also, are we going to backport 1742, if so do we need this one too? |
Been wondering the same. |
|
I vote for back-port this and #1742 |
We don't use this code. Cleanup step before longturn#1742.
lmoureaux
force-pushed
the
refactor/remove-is-beta-version
branch
from
918b9dc
to
1fc6fdf
Compare
|
Added #1742 to 3.0-stable then, though it's a bit risky so close to a release. |
jwrober
approved these changes
Feb 2, 2023
|
After further thought, taking this out of back-ports. Too risky so close to release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use this code. Cleanup step before #1742.