Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactors in utility/shared.h/cpp #2121

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Small refactors in utility/shared.h/cpp #2121

merged 3 commits into from
Jan 2, 2024

Conversation

lmoureaux
Copy link
Contributor

  • Remove a function provided by Qt
  • Switch a const char * to a QString (and update docs)
  • Fix a bug spotted by clangd

@lmoureaux lmoureaux requested a review from jwrober January 2, 2024 00:26
@lmoureaux lmoureaux mentioned this pull request Jan 2, 2024
Merged
jwrober
jwrober approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jwrober jwrober merged commit a1717d2 into longturn:master Jan 2, 2024
20 checks passed
@lmoureaux lmoureaux deleted the refactor/utility-2 branch January 2, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwrober jwrober jwrober approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmoureaux @jwrober