Move add-ons button to be with options #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @blabber for the suggestion
lmoureaux
approved these changes
Jan 15, 2024
|
I can push another commit to change the spelling. I chose add-ons since its much smaller and easier than modpacks, which to me has always been a weird name/word. I would not be opposed to renaming the modpack installer to something relating to add-ons. |
lmoureaux
approved these changes
Jan 15, 2024
|
For me, an add-on is something that extends functionality. In my opinion, the Freeciv modpacks are not add-ons, but "Mods". And that is also a common term in the field of computer games (at least in Germany). So it might even be more appropriate to rename the button to Mods? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @blabber for the suggestion. No related issue.