Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 15 new nations (rebased and fixed) #2259

Merged
merged 15 commits into from
Mar 31, 2024

Conversation

lmoureaux
Copy link
Contributor

@lmoureaux lmoureaux commented Mar 31, 2024

This solves all my concerns about #2199 and rebases it on top of current master. Unfortunately I cannot push to the original branch.

Closes #833
Closes #831
Closes #830
Closes #828
Closes #826
Closes #825
Closes #823

@lmoureaux lmoureaux requested a review from jwrober March 31, 2024 21:53
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Does this close any of the open issues we have for nations?

@lmoureaux
Copy link
Contributor Author

Looks good to me. Does this close any of the open issues we have for nations?

All except the first :)

Closes #833
Closes #831
Closes #830
Closes #828
Closes #826
Closes #825
Closes #823

@lmoureaux lmoureaux merged commit c8ab293 into longturn:master Mar 31, 2024
20 checks passed
@lmoureaux lmoureaux deleted the feature/new-nations branch March 31, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants