Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Clean Nuclear Fallout" to "Unit Controls" widget #2274

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

blabber
Copy link
Collaborator

@blabber blabber commented Apr 11, 2024

@blabber
Copy link
Collaborator Author

blabber commented Apr 11, 2024

Without this PR:
missing_fallout

With this PR:
fallout_fixed

@jwrober
Copy link
Collaborator

jwrober commented Apr 11, 2024

@blabber would you pls upload the save game you have w/ fallout?

@blabber
Copy link
Collaborator Author

blabber commented Apr 12, 2024

@blabber would you pls upload the save game you have w/ fallout?

🫴 fallout.sav.xz.zip

@jwrober
Copy link
Collaborator

jwrober commented Apr 13, 2024

You need to add fill="#000" to the top level <svg open tag for it to work for both light and dark themes. On my local I did this

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512" fill="#000" ...

@blabber
Copy link
Collaborator Author

blabber commented Apr 14, 2024

You need to add fill="#000" to the top level <svg open tag for it to work for both light and dark themes.

I changed fallout.svg as requested, but to be honest I still don't see any difference in light and dark theme (see screenshots below). Which irritates me even more, is that other icons (for example mine.svg) don't have this fill in their opening <svg ... tag.

Screenshots

Light theme

light

Dark theme

dark

@jwrober jwrober self-requested a review April 15, 2024 12:47
@jwrober
Copy link
Collaborator

jwrober commented Apr 15, 2024

Thanks for the update and submission of the icon. I am able to reproduce on my local too. I guess something is diff with how we do the unit controls bar vs other UI elements in the game that need that fill code.

@jwrober jwrober merged commit 4115667 into longturn:master Apr 15, 2024
20 checks passed
@blabber blabber deleted the feature/fallout_activity branch April 15, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Clean Fallout" activity is missing from the "Unit Controls" widget
2 participants