Use system Lua (>= 5.3) instead of a built-in version #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A specific version of Lua used to be required, but this is no longer the case (I think after commit 5aae933/PR longturn#417). Use the version of Lua provided by the system, requiring at least and prioritizing the widely available Lua 5.3. This should fix longturn#504.
Lua is now a hard dependency, so document it.
Qt log level enumerators are in a different order than old Freeciv ones. Debug is the smallest and Info is the largest.
|
Tested, seems to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The built-in Lua was not compatible with Lua modules installed using the platform's package manager. Using the system-provided Lua should improve compatibility, allowing to close #504.
document-me: Lua is no longer provided and Lua >=5.3 is now a hard dependency. This should improve interoperability with other Lua packages on your system.
Closes #504.