Fix errors related to scenarios #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client was crashing when loading a scenario, exiting the game, and trying to go back to the scenario page. The reason was that the list of scenarios is reloaded in this case, and the first time the loading code does is to clear the QListWidget holding the list of scenarios. This propagated to the "selection changed" callback that was trying to access the (nonexistant) first selected item, resulting in a crash. The fix is to check that there's something selected before trying to use it. See longturn#683.
I/O (or decompression) errors that occurred while reading spec files resulted in an infinite loop. This was the case e.g. when trying to read an empty file with ".gz" extension -- for instance, a failed save. Make sure that any error is properly handled and terminates reading the file. This makes the code a bit awful because the QIODevice error reporting API is just terrible.
lmoureaux
force-pushed
the
bugfix/scenarios
branch
from
746c82c
to
bd95baa
Compare
|
I can confirm that this patch fixes the crash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #683.