Add support for Zstandard compression #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zstandard is as fast as gzip and as good as xz. This makes it a good candidate for savegame compression. Support it when KArchive is recent enough. Leaving the default to xz for now, but we might want to revisit this in the future. Closes longturn#713.
Notably Homebrew and Ubuntu 20.04 used in our CI. See longturn#713.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zstandard is as fast as gzip and as good as xz. This makes it a good candidate for savegame compression. Support it when KArchive is recent enough.
Leaving the default to xz for now, but we might want to revisit this in the future.
Closes #713.
Test plan (you need KArchive 5.82 or later built with zst support):
set compresstype zstd